Mammouth du PHP |
19672 Messages
20 juil. 2005, 15:14
Je ne sais pas pour les autres,mais j'ai pour ma part toujours du mal à lire un code non indenté assortis d'espaces complètement superflus. Commence par mettre ton code en ordre, ce sera 50% minimum du débuggage parce que ça te fera découvrir que par exemple tes tableaux html ont des erreurs. Sans une indentation ocorrecte, c'est presque invisible à l'oeil si on ne s'attarde pas au ligne par ligne.
Par exemple, le premier code que tu as envoyé devrait ressembler à ceci:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<title>Clic loc bottle caps - Tablet bottles - Bags, Bottles & Containers - Veterinary Supplies - Safavet - VetClick</title>
<link rel="stylesheet" type="text/css" href="/stylesheets/vetclick2004.css">
<script language="JavaScript">
<!--
function verifier()
{
var myelt = document.form1.elements;
var pop;
var pp;
var isOk = true;
for (var i = 0; isOk && (i < myelt.length); i++)
{
if (myelt[i].className == "CB")
{
pop = document.getElementsByName(myelt[i].name+"POP").value;
pp = document.getElementsByName(myelt[i].name+"PP").value;
if(myelt[i].value)
{
if(parseFloat(pop)==0.0)
{
isOk = false;
}
}
else
{
if(parseFloat(pp)==0.0)
{
isOk = false;
}
}
}
}
if (!isOk)
{
alert('Sorry, a price is missing for an item. Please fill in the form properly.');
}
else
{
document.form1.submit();
}
}
// -->
</script>
</head>
<body>
<table border="0" cellpadding="0" cellspacing="1" height="100%" bgcolor="#000000">
<tr>
<td width="100" valign="top" bgcolor="#AACACC" nowrap> </td>
<td valign="top" width="100%" bgcolor="#ffffff">
<div class="BodyCopy">
<h5>Bags, Bottles & Containers</h5>
<h3>Tablet bottles</h3>
<h2>Clic loc bottle caps</h2>
<form name="form1" action="products.php?CatId=2&SubCatId=90&SubSubCatId=277" method="POST">
<table border="0" cellpadding="0" cellspacing="0">
<tr>
<td valign="top" align="left" colspan="2"> </td>
<td valign="middle" align="left" colspan="7"> </td>
</tr>
<tr>
<td valign="top" align="left" colspan="9"> </td>
</tr>
<tr>
<td colspan="9"> </td>
</tr>
<tr bgcolor="#f5f5f5" valign="middle" height="30">
<td width="50" nowrap> <b>Code</b></td>
<td nowrap><b>Product name</b></td>
<td nowrap align="center"> <b>Pack</b> </td>
<td nowrap align="center"> <b>List Price</b> </td>
<td nowrap align="center"> <font color="red"><b>Our Price</b></font> </td>
<td nowrap align="center"> <font color="green"><b>Offer Price</b></font> </td>
<td nowrap align="center"> <b>Offer is on ?</b> </td>
<td nowrap align="center"> <b>Saving</b> </td>
<td nowrap align="center"> </td>
</tr>
<tr>
<td colspan="9"> </td>
</tr>
<tr>
<td valign="top"><font face="verdana" size="1" color="black"> 78604</font></td>
<td valign="top" nowrap><font face="verdana" size="1" color="black">Clic loc bottle caps orange r3/20mm</font></td>
<td valign="top" align="center"><font face="verdana" size="1" color="black">100</font></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="black"> £ <input name="78604PLP" type="text" size="5" maxlength="8" value="3.98"></font></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="red"><b> £ </b><input class="PP" name="78604PP" type="text" size="5" maxlength="8" value="2.55"></font></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="green"> £ <input class="POP" name="78604POP" type="text" size="5" maxlength="8" value="0.00"></font></td>
<td nowrap valign="top" align="center"><input class="CB" type="checkbox" name="78604" value="ok"></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="black"> 56.08 % </font></td>
<td nowrap align="center"> </td>
</tr>
<tr>
<td colspan="9"><hr size="1" NOSHADE></td>
</tr>
<tr>
<td valign="top"><font face="verdana" size="1" color="black"> 78601</font></td>
<td valign="top" nowrap><font face="verdana" size="1" color="black"> Clic loc bottle caps green r3/22mm</font></td>
<td valign="top" align="center"><font face="verdana" size="1" color="black"> 100</font></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="black"> £<input name="78601PLP" type="text" size="5" maxlength="8" value="3.99"></font></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="red"><b> £ </b><input class="PP" name="78601PP" type="text" size="5" maxlength="8" value="2.90"></font></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="green"> £ <input class="POP" name="78601POP" type="text" size="5" maxlength="8" value="0.00"></font></td>
<td nowrap valign="top" align="center"><input class="CB" type="checkbox" name="78601" value="ok"></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="black"> 37.59 % </font></td>
<td nowrap align="center"> </td>
</tr>
<tr>
<td colspan="9"><hr size="1" NOSHADE></td>
</tr>
<tr>
<td valign="top"><font face="verdana" size="1" color="black"> 78599</font></td>
<td valign="top" nowrap><font face="verdana" size="1" color="black"> Clic loc bottle caps blue r3/24mm</font></td>
<td valign="top" align="center"><font face="verdana" size="1" color="black"> 100</font></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="black"> £ <input name="78599PLP" type="text" size="5" maxlength="8" value="4.52"></font></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="red"><b> £ </b><input class="PP" name="78599PP" type="text" size="5" maxlength="8" value="3.35"></font></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="green"> £ <input class="POP" name="78599POP" type="text" size="5" maxlength="8" value="0.00"></font></td>
<td nowrap valign="top" align="center"><input class="CB" type="checkbox" name="78599" value="ok"></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="black"> 34.93 % </font></td>
<td nowrap align="center"> </td>
</tr>
<tr>
<td colspan="9"><hr size="1" NOSHADE></td>
</tr>
<tr>
<td valign="top"><font face="verdana" size="1" color="black"> 78594</font></td>
<td valign="top" nowrap><font face="verdana" size="1" color="black"> Clic loc bottle caps red r3/28mm</font></td>
<td valign="top" align="center"><font face="verdana" size="1" color="black"> 100</font></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="black"> £<input name="78594PLP" type="text" size="5" maxlength="8" value="5.47"></font></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="red"><b> £ </b><input class="PP" name="78594PP" type="text" size="5" maxlength="8" value="3.80"></font></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="green"> £ <input class="POP" name="78594POP" type="text" size="5" maxlength="8" value="0.00"></font></td>
<td nowrap valign="top" align="center"><input class="CB" type="checkbox" name="78594" value="ok"></td>
<td nowrap valign="top" align="center"><font face="verdana" size="1" color="black"> 43.95 % </font></td>
<td nowrap align="center"> </td>
</tr>
<tr>
<td colspan="9"><hr size="1" NOSHADE></td>
</tr>
<tr>
<td width="100%" colspan="9"> </td>
</tr>
</table>
<input type="hidden" name="fieldnames" value="FIRST,78604,78601,78599,78594">
<input type="submit" name="submit" value="Submit" onClick="">
</form>
<br>
<br>
<br>
<b>Tablet bottles</b>
<br>
<br>
<table border="0" cellpadding="0" cellspacing="0">
<tr>
<td><b><a href="products.php?CatId=2&SubCatId=90&SubSubCatId=277">Clic loc bottle caps</a></b></td>
</tr>
<tr>
<td><b><a href="products.php?CatId=2&SubCatId=90&SubSubCatId=278">Plastic tablet bottle</a></b></td>
</tr>
</table>
<br>
<br>
<b>Bags, Bottles & Containers</b>
<br>
<br>
<table border="0" cellpadding="0" cellspacing="0">
<tr>
<td><b><a href="subcategory.php?CatId=2&SubCatId=87">Bags</a></b></td>
</tr>
<tr>
<td><b><a href="subcategory.php?CatId=2&SubCatId=86">Containers</a></b></td>
</tr>
<tr>
<td><b><a href="subcategory.php?CatId=2&SubCatId=90">Tablet bottles</a></b></td>
</tr>
</table>
<br>
<br>
<br> </div>
</td>
<td valign="top" width="100" bgcolor="#AACACC" nowrap></td>
</tr>
</table>
<!-- WebTrends Live Code -->
<script language="JavaScript" src="/webtrends/trackingcode.js"></script>
<NOSCRIPT>
<IMG BORDER="0" WIDTH="1" HEIGHT="1" SRC="http://statse.webtrendslive.com/S133588/button5.asp?tagver=5&si=133588&fw=1&js=No">
</NOSCRIPT>
<!-- End WebTrends Live Code -->
</body>
</html>
Il me semble que c'est tout de suite plus clair, non ?
Quant à la dernière note de
mere-teresa à propos de la différence entre submit et submit(), c'est pas dur: tu confonds le nom du bouton et le nom de la fonction JavaScript : fais l'expérience suivante : dans ta balise input type="submit" , change l'attribut name="submit" en name="envoi" : ça va peut-être t'aider à saisir la différence.
Codez en pensant que celui qui maintiendra votre code est un psychopathe qui connait votre adresse 